fix: build failed in qt5#313
Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom Apr 29, 2025
Merged
Conversation
Changed Q_GLOBAL_STATIC to Q_GLOBAL_STATIC_WITH_ARGS for OrgDeepinDTKPreference initialization This modification provides better type safety and clearer syntax for the complex initialization parameters The change maintains the same functionality while following Qt's recommended practices for static initialization refactor: 更新 DConfig 初始化语法 将 Q_GLOBAL_STATIC 改为 Q_GLOBAL_STATIC_WITH_ARGS 用于 OrgDeepinDTKPreference 初始化 此修改为复杂的初始化参数提供了更好的类型安全性和更清晰的语法 该变更保持了相同的功能，同时遵循 Qt 推荐的静态初始化实践
Contributor
deepin pr auto review关键摘要:
是否建议立即修改:
其他建议:
|
deepin-ci-robot
added a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Apr 29, 2025
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#313
Contributor
|
Note
详情{
"src/kernel/dguiapplicationhelper.cpp": [
{
"line": " QString socket_key = \"_d_dtk_single_instance_\";",
"line_number": 1468,
"rule": "S106",
"reason": "Var naming | 2ad926d35b"
}
]
} |
mhduiy
approved these changes
Apr 29, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
18202781743
pushed a commit
to linuxdeepin/dtk6gui
that referenced
this pull request
Apr 29, 2025
Synchronize source files from linuxdeepin/dtkgui. Source-pull-request: linuxdeepin/dtkgui#313
Contributor
|
This pr force merged! (status: blocked) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed Q_GLOBAL_STATIC to Q_GLOBAL_STATIC_WITH_ARGS for
OrgDeepinDTKPreference initialization
This modification provides better type safety and clearer syntax for the
complex initialization parameters
The change maintains the same functionality while following Qt's
recommended practices for static initialization
refactor: 更新 DConfig 初始化语法
将 Q_GLOBAL_STATIC 改为 Q_GLOBAL_STATIC_WITH_ARGS 用于
OrgDeepinDTKPreference 初始化
此修改为复杂的初始化参数提供了更好的类型安全性和更清晰的语法
该变更保持了相同的功能，同时遵循 Qt 推荐的静态初始化实践